Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (YouTube / YouTube Music): Show a tost if original app not instaled #2922

Closed
3 tasks done
MarcaDian opened this issue Mar 27, 2024 · 4 comments
Closed
3 tasks done
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@MarcaDian
Copy link
Contributor

Feature description

Hello, In response to this PR #2907

After migrating to the new ReVanced GmsCore vendor, many users encountered an application crash after installing ReVanced YouTube / ReVanced YouTube Music
I propose to check for installed versions of the original YouTube and YouTube Music applications, and if they are not installed, then show a toast asking you to install it.

Here's an explanation why this happens #2907 (comment)

Motivation

This will prevent users from misunderstanding why ReVanced Youtube or/and ReVanced Youtube Music crashes without any notification.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@MarcaDian MarcaDian added the Feature request Requesting a new feature that's not implemented yet label Mar 27, 2024
@oSumAtrIX
Copy link
Member

I think that's already implemented

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
@LisoUseInAIKyrios
Copy link
Contributor

Is this implemented? If YT is completely uninstalled using ADB (or somehow the phone does not include YT pre installed), then the app still crashes without an explanation.

As far as I know, an app can only check for the existence of other apps if a manifest permission is added (not ideal), or the other app must be launched thru an intent (definitely not ideal).

Maybe an additional patch hook could be added where the YT exception is generated, and show a toast informing the user to install unpatched YT.

@oSumAtrIX
Copy link
Member

Unless I completely forgot pushing the changes, I have added the same hook that is present on YouTube to YouTube Music as well.

@oSumAtrIX
Copy link
Member

Yes, seems to be present: https://github.com/ReVanced/revanced-patches/blob/dev/src/main/kotlin/app/revanced/patches/shared/misc/gms/BaseGmsCoreSupportPatch.kt

The integrations should probably move to "shared", seems I forgot to do that, but in theory the same behaviour as seen on YouTube should occur in YouTube Music. If not, a bug report should be opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants