-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YouTube): Add Exit fullscreen mode
patch
#4223
feat(YouTube): Add Exit fullscreen mode
patch
#4223
Conversation
d903963
to
615b501
Compare
It was easier than I thought 😁 |
Very. I spent longer typing out all the boiler plate code and resources than making the actual patch. |
Continuing the idea, it would be cool to add the ability not to exit full-screen mode when returning to the player, for example, after unlocking the screen. |
LOL...you can save the previous player state in a field and use this to send a onClick() event to the same button again...once the player quit from fullscreen. |
...but, honestly, idk if this approach will increase the patch complexity too much. |
It might be easier, and probably more reliable, to instead patch the logic that switches from fullscreen to portrait when the app is resumed. |
I once used a similar function in another fork, but there was a bug in PiP mode on some firmwares (in my case, MIUI), although no such bug was detected in others. |
615b501
to
1ecfdcc
Compare
@LisoUseInAIKyrios yeah, it is, but if you want to speed up the patch development...xD |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
# [5.8.0-dev.4](v5.8.0-dev.3...v5.8.0-dev.4) (2024-12-27) ### Bug Fixes * **GmsCore support:** Do not show battery optimization error on Android Automotive devices (Google built-in) ([#4218](#4218)) ([d6e389c](d6e389c)) ### Features * **Swipe controls:** Add option to enable/disable fullscreen swipe to next video ([#4222](#4222)) ([119092f](119092f)) * **YouTube:** Add `Exit fullscreen mode` patch ([#4223](#4223)) ([bb5d03b](bb5d03b))
# [5.8.0](v5.7.2...v5.8.0) (2024-12-30) ### Bug Fixes * **GmsCore support:** Do not show battery optimization error on Android Automotive devices (Google built-in) ([#4218](#4218)) ([d6e389c](d6e389c)) * **YouTube - Exit fullscreen mode:** Exit fullscreen mode of first video opened after cold start ([be5cf2e](be5cf2e)) * **YouTube - Force original audio:** If stream spoofing to Android then show a summary text why force audio is not available ([#4220](#4220)) ([029aee8](029aee8)) * **YouTube - Spoof video streams:** Ignore harmless error toast if hide ads is disabled ([c3423bb](c3423bb)) ### Features * **Swipe controls:** Add option to enable/disable fullscreen swipe to next video ([#4222](#4222)) ([119092f](119092f)) * **YouTube - Hide Shorts components:** Add option to hide Shorts in watch history ([#4214](#4214)) ([19c2742](19c2742)) * **YouTube - Spoof app version:** Add 'Restore old navigation and toolbar icons' ([f84e459](f84e459)) * **YouTube:** Add `Change form factor` patch ([#4217](#4217)) ([644ac5b](644ac5b)) * **YouTube:** Add `Exit fullscreen mode` patch ([#4223](#4223)) ([bb5d03b](bb5d03b)) * **YouTube:** Add in app option to select a preferred language for ReVanced specific text ([#4231](#4231)) ([3932af3](3932af3))
Adds an option to exit fullscreen mode at the end of a video.
Works well with
Open Shorts in regular player
and the fullscreen player.