Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube): Add in app option to select a preferred language for ReVanced specific text #4231

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Dec 27, 2024

Adds an in app setting to pick a language for all ReVanced specific strings, while still using the original app language.

So YouTube can now use a foreign language but still show English ReVanced strings.

@LisoUseInAIKyrios
Copy link
Contributor Author

After eventually finding the right method to override, this was way easier to implement than I expected (Android Preferences are trash).

@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/settings_in_app_language_choice branch from 6578fa1 to 9f3b50b Compare December 27, 2024 15:32
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/settings_in_app_language_choice branch from c898ab5 to fbf07cf Compare December 27, 2024 21:14
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 3932af3 into ReVanced:dev Dec 28, 2024
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the feat/settings_in_app_language_choice branch December 28, 2024 08:31
github-actions bot pushed a commit that referenced this pull request Dec 28, 2024
# [5.8.0-dev.8](v5.8.0-dev.7...v5.8.0-dev.8) (2024-12-28)

### Features

* **YouTube:** Add in app option to select a preferred language for ReVanced specific text ([#4231](#4231)) ([3932af3](3932af3))
github-actions bot pushed a commit that referenced this pull request Dec 30, 2024
# [5.8.0](v5.7.2...v5.8.0) (2024-12-30)

### Bug Fixes

* **GmsCore support:** Do not show battery optimization error on Android Automotive devices (Google built-in) ([#4218](#4218)) ([d6e389c](d6e389c))
* **YouTube - Exit fullscreen mode:** Exit fullscreen mode of first video opened after cold start ([be5cf2e](be5cf2e))
* **YouTube - Force original audio:** If stream spoofing to Android then show a summary text why force audio is not available ([#4220](#4220)) ([029aee8](029aee8))
* **YouTube - Spoof video streams:** Ignore harmless error toast if hide ads is disabled ([c3423bb](c3423bb))

### Features

* **Swipe controls:** Add option to enable/disable fullscreen swipe to next video ([#4222](#4222)) ([119092f](119092f))
* **YouTube - Hide Shorts components:** Add option to hide Shorts in watch history ([#4214](#4214)) ([19c2742](19c2742))
* **YouTube - Spoof app version:** Add 'Restore old navigation and toolbar icons' ([f84e459](f84e459))
* **YouTube:** Add `Change form factor` patch ([#4217](#4217)) ([644ac5b](644ac5b))
* **YouTube:** Add `Exit fullscreen mode` patch ([#4223](#4223)) ([bb5d03b](bb5d03b))
* **YouTube:** Add in app option to select a preferred language for ReVanced specific text ([#4231](#4231)) ([3932af3](3932af3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants