Merge pull request #3656 from bbonnet/fix-timeout-error-name

fix(ajax): RxJS v6 TimeoutError is missing name property

spec/observables/dom/ajax-spec.ts

@@ -273,6 +273,7 @@ describe('Observable.ajax', () => {
     });
 
     expect(error instanceof Rx.AjaxError).to.be.true;
+    expect(error.name).to.equal('AjaxError');
     expect(error.message).to.equal('ajax error 404');
     expect(error.status).to.equal(404);
   });
@@ -843,7 +844,7 @@ describe('Observable.ajax', () => {
     delete root.XMLHttpRequest.prototype.onreadystatechange;
   });
 
-  it('should work fine when XMLHttpRequest ontimeout property is monkey patched', function() {
+  it('should work fine when XMLHttpRequest ontimeout property is monkey patched', function(done) {
     Object.defineProperty(root.XMLHttpRequest.prototype, 'ontimeout', {
       set(fn: (e: ProgressEvent) => any) {
         const wrapFn = (ev: ProgressEvent) => {
@@ -867,7 +868,8 @@ describe('Observable.ajax', () => {
     Rx.Observable.ajax(ajaxRequest)
       .subscribe({
         error(err) {
-          /* expected, ignore */
+          expect(err.name).to.equal('AjaxTimeoutError');
+          done();
         }
       });
 

spec/operators/timeout-spec.ts

@@ -25,14 +25,17 @@ describe('Observable.prototype.timeout', () => {
   it('should emit and error of an instanceof TimeoutError on timeout', () => {
     const e1 =  cold('-------a--b--|');
     const result = e1.timeout(50, rxTestScheduler);
+    let error;
     result.subscribe(() => {
       throw new Error('this should not next');
     }, err => {
-      expect(err).to.be.an.instanceof(Rx.TimeoutError);
+      error = err;
     }, () => {
       throw new Error('this should not complete');
     });
     rxTestScheduler.flush();
+    expect(error).to.be.an.instanceof(Rx.TimeoutError);
+    expect(error.name).to.equal('TimeoutError');
   });
 
   it('should not timeout if source completes within absolute timeout period', () => {

src/internal/observable/dom/AjaxObservable.ts

@@ -490,6 +490,7 @@ function parseXhrResponse(responseType: string, xhr: XMLHttpRequest) {
 export class AjaxTimeoutError extends AjaxError {
   constructor(xhr: XMLHttpRequest, request: AjaxRequest) {
     super('ajax timeout', xhr, request);
+    this.name = 'AjaxTimeoutError';
     (Object as any).setPrototypeOf(this, AjaxTimeoutError.prototype);
   }
 }

src/internal/util/TimeoutError.ts

@@ -8,7 +8,7 @@
 export class TimeoutError extends Error {
   constructor() {
     super('Timeout has occurred');
-
+    this.name = 'TimeoutError';
     (Object as any).setPrototypeOf(this, TimeoutError.prototype);
   }
 }