Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AnonymousSubject public in v6+ #3869

Closed
Sawtaytoes opened this issue Jun 27, 2018 · 2 comments
Closed

Make AnonymousSubject public in v6+ #3869

Sawtaytoes opened this issue Jun 27, 2018 · 2 comments

Comments

@Sawtaytoes
Copy link

Sawtaytoes commented Jun 27, 2018

Feature Request

Is your feature request related to a problem? Please describe.
In a prior issue (#2002), AnonymousSubject was made public. Problem is, AnonymousSubject is no longer in the main index.js file in v6. I have to go to rxjs/internal to get to it.

Describe the solution you'd like
I'd like to see AnonymousSubject made public again in v6 and on.

Describe alternatives you've considered
Using rxjs/internal.

Additional context
In RxJS v5, I made a SignalRHubConnection observable for the C# SignalR similar to the WebSocket version which also used AnonymousSubject. I don't feel comfortable referencing things in rxjs/internal for my own observables using internal functionality.

@frankwallis
Copy link

Reference to same v5 issue: #2002

Also I have found that importing from rxjs/internal can cause big increases in the webpack bundle size for some reason.

@kwonoj
Copy link
Member

kwonoj commented Sep 25, 2018

Related with #3513 : eventually we may want to change fate of anonymous subject itself, not sure we'll expose it as public interface at the moment.

@kwonoj kwonoj closed this as completed Sep 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants