Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallbacks for setUrlUtm function #309

Merged
merged 2 commits into from
Jul 19, 2020
Merged

fallbacks for setUrlUtm function #309

merged 2 commits into from
Jul 19, 2020

Conversation

mbifulco
Copy link
Member

Describe your PR

This is an attempt to fix a bug caused by bad URLs being passed into this utility function

Related to #
Fixes # prod bug

Pages/Interfaces that will change

/business

Steps to test

  1. let this branch build and deploy to netlify
  2. test the /business page with knosn good and bad URLs

Additional notes

@mbifulco mbifulco self-assigned this Jul 19, 2020
@mbifulco mbifulco requested a review from elchris July 19, 2020 21:19
@mbifulco mbifulco added the bug Something isn't working label Jul 19, 2020
racedale
racedale approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@racedale racedale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should follow up by adding a test around this scenario

@mbifulco mbifulco merged commit 5cef5e4 into main Jul 19, 2020
@mbifulco mbifulco deleted the fix/url-bug branch July 19, 2020 21:27
@mbifulco mbifulco mentioned this pull request Jul 19, 2020
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racedale racedale racedale approved these changes

@domitriusclark domitriusclark Awaiting requested review from domitriusclark domitriusclark is a code owner

@magnificode magnificode Awaiting requested review from magnificode magnificode is a code owner

@elchris elchris Awaiting requested review from elchris

Assignees

@mbifulco mbifulco

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbifulco @racedale