Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change Halo theme font-weight 600 from bold to semibold #377

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

dtanp-rft
Copy link
Collaborator

Description

In Halo theme, font-weight 600 should be semibold. However, EF theme map 500 to semibold and 700 to bold. This means that font-weight 600 will be bold font.

We should map 600 to semibold and keep 500 to semibold as well so it won't have any impacts that using 500 with semibold.

In theme, we also want to replace anywhere that use font-weight 500 to 600 so it will be clean and match to Figma file.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 24, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9552c6c
Status: ✅  Deploy successful!
Preview URL: https://0a889bb7.refinitiv-ui.pages.dev
Branch Preview URL: https://fix-simi-bold-font.refinitiv-ui.pages.dev

View logs

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dtanp-rft dtanp-rft merged commit 485221e into v6 Jun 27, 2022
@wsuwt wsuwt deleted the fix/simi-bold-font branch September 26, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants