-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/memory leak translate directive removing wrong observer key #577
Merged
Sarin-Udompanish
merged 9 commits into
v6
from
fix/memory-leak-translate-directive-removing-wrong-observer-key
Jan 26, 2023
Merged
Fix/memory leak translate directive removing wrong observer key #577
Sarin-Udompanish
merged 9 commits into
v6
from
fix/memory-leak-translate-directive-removing-wrong-observer-key
Jan 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rong-observer-key
…ix/memory-leak-translate-directive-removing-wrong-observer-key
…rver-key' of https://github.com/Refinitiv/refinitiv-ui into fix/memory-leak-translate-directive-removing-wrong-observer-key
…rong-observer-key
…rong-observer-key
Deploying with Cloudflare Pages
|
Size Change: +24 B (0%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
Kudos, SonarCloud Quality Gate passed! |
TremayneChrist
approved these changes
Jan 26, 2023
Sarin-Udompanish
deleted the
fix/memory-leak-translate-directive-removing-wrong-observer-key
branch
January 26, 2023 10:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an element using the translate directive is created, it will retrieve the key from the Phrasebook and store it in the key variable within the translate scope.
However, the translate directive is only called once, unless a new element with the same name is created.
As a result, the key variable will be replaced each time, leading to a memory leak since the Phrasebook will only remove the most recent element reference.
Type of change