Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output of JsonIgnore attributes #1522

Merged
merged 6 commits into from
Aug 15, 2022

Conversation

AroglDarthu
Copy link
Contributor

Attempt to fix RicoSuter/NSwag#4012
I'm not entirely certain on how to find out if the property is a value type.
Please have a look and tell me what you think.

@HavenDV
Copy link

HavenDV commented Jul 13, 2022

I think you need to delete ValueTypeFormats

@AroglDarthu AroglDarthu reopened this Jul 13, 2022
@AroglDarthu
Copy link
Contributor Author

AroglDarthu commented Jul 13, 2022

@RicoSuter any thoughts from you on this one? It kind of prevents people that use System.Text.Json (like myself) from using versions above 13.15.10

@binginsin
Copy link
Contributor

@RicoSuter could you please have a look? This is still a serious issue and is causing problems, would be good to get this merged in.

@RicoSuter RicoSuter merged commit b4d81b0 into RicoSuter:master Aug 15, 2022
@RicoSuter
Copy link
Owner

Lgtm, thanks for the Pr.

@abrasat
Copy link

abrasat commented Aug 18, 2022

@RicoSuter Could you please update the nuget packages with this fix?

@bdovaz
Copy link

bdovaz commented Sep 3, 2022

We need a NuGet package update, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ignore condition 'JsonIgnoreCondition.WhenWritingNull' is not valid on value-type member
7 participants