Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Code for roomID extractions #22

Closed
Rishabh-malhotraa opened this issue Mar 25, 2021 · 8 comments · Fixed by #32
Closed

Refactor Code for roomID extractions #22

Rishabh-malhotraa opened this issue Mar 25, 2021 · 8 comments · Fixed by #32
Assignees
Labels
enhancement ✨ New feature or request good first issue Good for newcomers

Comments

@Rishabh-malhotraa
Copy link
Owner

Motivation

I want to adhere to the DRY concept in programming (Don't Repeat Yourself)

Description

In many files, I have resued the logic to extract the param id from the URL. Firstly I thought I wouldn't need it but then I have rewritten the same code in different files several times.

A better implementation would be to use context and store it as a part of the global state

import { useParams } from "react-router-dom";
const { id } = useParams<Record<string, string>>();
@Rishabh-malhotraa Rishabh-malhotraa added enhancement ✨ New feature or request good first issue Good for newcomers labels Mar 25, 2021
@dipenr06
Copy link

dipenr06 commented Sep 27, 2021

Hey @Rishabh-malhotraa , I would like to work on this please.. and please guide me on how can i contribute to this as i'm new here 😅

@Rishabh-malhotraa
Copy link
Owner Author

You should start by setting up the project locally, make the required changes, and make a pull request.
I'll then do a code review on your changes and give you feedback, if needed; and then your PR will be merged to the codebase :).

@dipenr06
Copy link

sure thank you so much

@MarufSharifi
Copy link
Collaborator

Hey @Rishabh-malhotraa , could i solve this issue

@MarufSharifi
Copy link
Collaborator

Hi @Rishabh-malhotraa, I have just cloned this repository and after that i installed dependencies, but unfortunately if face to this issue

Can't resolve 'tsparticles' in '/home/manujtiwari/Desktop/portfolio-react/node_modules/react-particles-js/cjs'

I have solved the issue by installing "tsparticles" npm package .
should i commit the change that i have made to this repository

@Rishabh-malhotraa
Copy link
Owner Author

Rishabh-malhotraa commented Sep 29, 2021

@MarufSharifi Sure go right ahead, make a pr and I'll merge it

@MarufSharifi
Copy link
Collaborator

I had made pr, please check.

@MarufSharifi
Copy link
Collaborator

Hey @Rishabh-malhotraa, thanks a lot for helping me, the problem have gone, when i used npm to install packages, because of that i closed the pr and deleted that branch. right now i am working on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants