-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Code for roomID extractions #22
Comments
Hey @Rishabh-malhotraa , I would like to work on this please.. and please guide me on how can i contribute to this as i'm new here 😅 |
You should start by setting up the project locally, make the required changes, and make a pull request. |
sure thank you so much |
Hey @Rishabh-malhotraa , could i solve this issue |
Hi @Rishabh-malhotraa, I have just cloned this repository and after that i installed dependencies, but unfortunately if face to this issue
I have solved the issue by installing "tsparticles" npm package . |
@MarufSharifi Sure go right ahead, make a pr and I'll merge it |
I had made pr, please check. |
Hey @Rishabh-malhotraa, thanks a lot for helping me, the problem have gone, when i used npm to install packages, because of that i closed the pr and deleted that branch. right now i am working on this issue |
Motivation
I want to adhere to the DRY concept in programming (Don't Repeat Yourself)
Description
In many files, I have resued the logic to extract the param id from the URL. Firstly I thought I wouldn't need it but then I have rewritten the same code in different files several times.
A better implementation would be to use context and store it as a part of the global state
The text was updated successfully, but these errors were encountered: