-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segfault with roaring64 intersect_with_range and empty bitmap #636
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Looks like I can get something similar with |
I think the right place to fix this would be in |
d292fd3
to
81c97d9
Compare
When we reset the iterator to the root, check if the root is null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should merge and release 'soon'.
Ready when you are 👍 |
@Dr-Emann I am re-running a failed test which I do not expect to be related to this PR. |
Anything else to do here? Would like to get this in and have a release with this in it. |
Release upcoming. |
Fixes #635, and adds some tests
@SLieve, is this the right place to do this? The segfault under valgrind:
The actual error seems to comes from
art_node_iterator_lower_bound
when passed a NULL node, not sure if this is the right place to guard, or if something lower down in the call chain should handle an empty bitmap better.