Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only ignore amalgamation files at the root #641

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

Dr-Emann
Copy link
Member

@Dr-Emann Dr-Emann commented Jul 4, 2024

Currently, the gitignore tries to ignore src/roaring.c

This actually only works in git because git only considers the gitignore when it would add a file to be tracked, changes to existing files already in git are tracked regardless of what's in .gitignore.

Fixes #637

Currently, the gitignore tries to ignore src/roaring.c

This actually only works in gitignore because git only considers the gitignore
when it would _add_ a file to be tracked, changes to existing files already in
git are tracked regardless of what's in .gitignore.

Fixes #637
@Dr-Emann Dr-Emann requested a review from lemire July 4, 2024 19:57
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dr-Emann Dr-Emann merged commit 8bcc0ef into master Jul 8, 2024
38 checks passed
@Dr-Emann Dr-Emann deleted the push-kyuxuxmmwuys branch July 8, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitignore tries to ignore src/roaring.c, etc
2 participants