import roaring.h from the right place #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemire
approved these changes
Sep 5, 2024
Only add `include/`, so includes must be done as `<roaring/xxx.h>`. Also, fix an issue where `CMAKE_INSTALL_INCDIR` was referenced, the correct variable is `CMAKE_INSTALL_INCLUDEDIR`: https://cmake.org/cmake/help/latest/command/install.html
|
Agreed, changed the CMake to only add |
|
Merging. |
|
Recommend another release, believe this could break compiles for users. |
|
@Dr-Emann Major or minor version? |
|
I'd say patch version, it's just a fix, no new functionality or breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be expecting
roaring.hto be available in the header search path directly.