Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue 660 #661

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fixing issue 660 #661

merged 2 commits into from
Sep 19, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Sep 19, 2024

Fixes #660

@Dr-Emann
Copy link
Member

So this would have failed (not necessarily with a segfault, but at least logical out of bounds write) for any bitmap where the max value was evenly divisible by 64, I believe (the only case where max / 64 + 1 != (max + 63) / 64)

include/roaring/roaring64.h Show resolved Hide resolved
tests/roaring64_unit.cpp Show resolved Hide resolved
@lemire lemire merged commit 51be4bd into master Sep 19, 2024
37 of 38 checks passed
@Dr-Emann Dr-Emann deleted the issue660 branch September 19, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting bitmap with only index 0 set to bitset segfaults
2 participants