Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong information in README.md #1094

Closed
derskythe opened this issue Sep 20, 2024 · 1 comment
Closed

Wrong information in README.md #1094

derskythe opened this issue Sep 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@derskythe
Copy link

Describe the bug.

Hello @RogueMaster,
Your README.md file contains wrong information about the SubGhz Frequency Analyzer.
You wrote:

SubGHz: New frequency analyzer flipperdevices#1501 feedback mode (by darmiel) Quiet Mode (by Himura2la) flipperdevices#1557

The current version of the file does not contain the code of some authors. Also, there is functionality that you did not describe. The links to the PR are also incorrect.

Below are the correct links and functionality:

  • Ability to set RSSI trigger level, Sound and vibration on signal detect by @ClusterM (PR #43)
  • Long press OK button in SubGHz Frequency analyzer switch to Read menu with selected frequency by @derskythe (PR #79)
  • Sync with OFW for brand new interface and improve to 4 elements of history, abillity to disable sound and vibro with saving by @derskythe (PR #121)
  • Add CC1101 module external support by @gid9798 (PR #534)
  • And many-many bugfixes from @xMasterX

Reproduction

None

Target

No response

Logs

No response

Anything else?

Have a nice day

@derskythe derskythe added the bug Something isn't working label Sep 20, 2024
@RogueMaster
Copy link
Owner

Thanks for the feedback, the appropriate application.fam will be updated, however, please note:

These changes New frequency analyzer #1557 (By ClusterM) were here far before they were taken from the UL PR. This PR predates the UL PR.

Also, feedback mode (by darmiel) and Quiet Mode (by Himura2la) (Link Dead) ideas were taken and used by OFW and merged with no credit here: Sync with OFW for brand new interface and improve to 4 elements of history, abillity to disable sound and vibro with saving (By derskythe) These features were in RM far before they were merged into UL and OFW and proper credit will remain given for the creators for these ideas/features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants