Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for RN 0.72.1 New arch use_frameworks! #265

Closed
billnbell opened this issue Jul 5, 2023 · 2 comments
Closed

Fix for RN 0.72.1 New arch use_frameworks! #265

billnbell opened this issue Jul 5, 2023 · 2 comments

Comments

@billnbell
Copy link

Ok here is a patch for fixing [react-native-blob-util] for RN 0.72.1 new arch / Fabric.

patches/react-native-blob-util+0.18.3.patch

diff --git a/node_modules/react-native-blob-util/ios/ReactNativeBlobUtil/ReactNativeBlobUtil.h b/node_modules/react-native-blob-util/ios/ReactNativeBlobUtil/ReactNativeBlobUtil.h
index 825cdfc..aa4dddb 100644
--- a/node_modules/react-native-blob-util/ios/ReactNativeBlobUtil/ReactNativeBlobUtil.h
+++ b/node_modules/react-native-blob-util/ios/ReactNativeBlobUtil/ReactNativeBlobUtil.h
@@ -29,7 +29,7 @@
 #import <UIKit/UIKit.h>
 
 #if RCT_NEW_ARCH_ENABLED
-#import <React-Codegen/ReactNativeBlobUtilSpec/ReactNativeBlobUtilSpec.h>
+#import <ReactNativeBlobUtilSpec/ReactNativeBlobUtilSpec.h>
 #endif
 
 
diff --git a/node_modules/react-native-blob-util/react-native-blob-util.podspec b/node_modules/react-native-blob-util/react-native-blob-util.podspec
index acc6380..aecb333 100644
--- a/node_modules/react-native-blob-util/react-native-blob-util.podspec
+++ b/node_modules/react-native-blob-util/react-native-blob-util.podspec
@@ -1,7 +1,6 @@
 require "json"
-package = JSON.parse(File.read('package.json'))
 
-folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32'
+package = JSON.parse(File.read(File.join(__dir__, "package.json")))
 
 Pod::Spec.new do |s|
   s.name             = package['name']
@@ -15,22 +14,6 @@ Pod::Spec.new do |s|
   s.source_files = 'ios/**/*.{h,m,mm,swift}'
   s.platform     = :ios, "8.0"
   s.framework    = 'AssetsLibrary'
+  install_modules_dependencies(s)
 
-  s.dependency 'React-Core'
-
-  if ENV["RCT_NEW_ARCH_ENABLED"] == "1"
-    s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
-    s.pod_target_xcconfig    = {
-      "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
-      "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
-      "CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
-    }
-
-    s.dependency "React-Codegen"
-    s.dependency "React-RCTFabric"
-    s.dependency "RCT-Folly"
-    s.dependency "RCTRequired"
-    s.dependency "RCTTypeSafety"
-    s.dependency "ReactCommon/turbomodule/core"
-  end
 end
@billnbell
Copy link
Author

#266

@billnbell
Copy link
Author

can we get this applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant