Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to pass custom multicallDeploymentBlockNumbers constants #56

Open
4 tasks
vad99lord opened this issue Nov 14, 2023 · 2 comments
Open
4 tasks
Assignees
Labels
enhancement New feature or request

Comments

@vad99lord
Copy link

vad99lord commented Nov 14, 2023

Feature Request

It's currently not possible to pass extra constants to multicall3DeploymentBlockNumbers. I have a network that already has a deployed copy of the multicall contract from the list (i.e. Mantle). However, currently not all of the chains are represented in multicall3DeploymentBlockNumbers, so it's not feasible to provide a custom block number in a call.

Describe the solution you'd like
I'd like a way to pass extra chains info, so it's possible to augment the existing configs in a library. I'm not sure what would be the more convenient format since it seems like an internal library module.

Describe alternatives you've considered
Patching the package locally with a constants object.

Are you willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time, and I know how to start.
  • Yes, I have the time, but I don't know how to start. I would need guidance.
  • No, I don't have the time, although I believe I could do it if I had the time...
  • No, I don't have the time and I wouldn't even know how to start.
@vad99lord vad99lord added the enhancement New feature or request label Nov 14, 2023
@Rubilmax Rubilmax self-assigned this Nov 14, 2023
@bytes0xcr6
Copy link

Hi guys! Are you working on this?

@Rubilmax
Copy link
Owner

Hi, is it possible for you to add the chain id and the deployment block number to multicall3DeploymentBlockNumbers?

multicall3DeploymentBlockNumbers[mantle.chainid] = deploymentBlockNumber;

I can also simply add mantle to the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants