Master: Fix tests on Windows, add Ruby 3.3, and cleanup CI #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
force-pushed
the
master-fix-tests-windows
branch
2 times, most recently
from
99ec80d
to
27d6c02
Compare
|
@pitbulk this is ready to be merged. The JRuby |
johnnyshields
force-pushed
the
master-fix-tests-windows
branch
from
27d6c02
to
c21cb22
Compare
johnnyshields
changed the title
johnnyshields
force-pushed
the
master-fix-tests-windows
branch
from
c21cb22
to
1b74fab
Compare
|
@pitbulk this can be merged independently of the other PRs. |
|
This PR has a mix of the code to be sent to V2 and the one to master branch |
johnnyshields
force-pushed
the
master-fix-tests-windows
branch
from
1b74fab
to
0f8da70
Compare
|
@pitbulk oops! Sorry about that, its now fixed and ready to merge. |
|
@johnnyshields, We should also apply this on V2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the DateTime class struggles with Float values for certain methods like
#next_yearsome reason.