Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: Remove deprecated settings.security[:embed_sign] parameter #690

Merged

Conversation

johnnyshields
Copy link
Collaborator

@johnnyshields johnnyshields commented Jul 8, 2024

This is a cleanup of #606

@johnnyshields johnnyshields changed the base branch from master to v2.x July 8, 2024 14:22
@johnnyshields johnnyshields force-pushed the remove-embed-sign-parameter branch from 3e81b73 to 52cf370 Compare July 8, 2024 14:25
…n be migrated to idp_sso/slo_service_binding.
@johnnyshields johnnyshields force-pushed the remove-embed-sign-parameter branch from 10c95bd to 4a2ab3e Compare July 9, 2024 03:58
@johnnyshields
Copy link
Collaborator Author

johnnyshields commented Jul 9, 2024

@pitbulk ready for your review and merge.

Since :embed_sign was deprecated in v1.3 I think it's safe to just remove it outright. In general, the correct params should already be set by IdPMetadataParser.

By the way, if we want to do a deprecation warning here, we'd have to do something like: #694

@pitbulk
Copy link
Collaborator

pitbulk commented Jul 9, 2024

Let's resolve conflicts and we can merge this.

@pitbulk pitbulk merged commit e9c7f97 into SAML-Toolkits:v2.x Jul 9, 2024
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants