v2.0: Move XMLSecurity namespace to RubySaml::XML #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
force-pushed
the
xml-security-to-rubysaml-xml
branch
from
4301bab to
90eb359
Compare
johnnyshields
force-pushed
the
xml-security-to-rubysaml-xml
branch
from
90eb359 to
8565353
Compare
|
@johnnyshields Can we keep for backward compatibility the file xml_security.rb that gonna include the requires of the new files that replaced its content, similar than the work done on ruby-saml.rb? |
|
@pitbulk changes done as requested. |
johnnyshields
force-pushed
the
xml-security-to-rubysaml-xml
branch
from
3c5127b to
ff1cf3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is done in the same manner as the OneLogin removal. It also splits out the multiple inner classes into individual files.
The PR also includes a test for alias XMLSecurity = RubySaml::XML