Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Luigi Core FD Styles to 0.11.0 #1542

Closed
UlianaMunich opened this issue Aug 7, 2020 · 0 comments · Fixed by #1569
Closed

Migrate Luigi Core FD Styles to 0.11.0 #1542

UlianaMunich opened this issue Aug 7, 2020 · 0 comments · Fixed by #1569
Assignees
Labels
Milestone

Comments

@UlianaMunich
Copy link
Contributor

UlianaMunich commented Aug 7, 2020

FD Styles 0.11.0
Applicable breaking changes:

  • updates to SideNavigation (Nested Lists) for accessibility (Side navigation - compact mode #1012) (5d1f7c4)
  • shellbar button outlines should follow behavior of transparent buttons and have buttons instead of divs
  • removed classes fd-overlay, fd-overlay--alert, and fd-overlay--message-strip (Means alert messages broken)
  • All .sap-icon--* were removed (sap-icon--s, sap-icon--small, sap-icon--m, sap-icon--medium, sap-icon--l etc. )

Rest needs to be double checked
Breaking changes for this version:
https://github.com/SAP/fundamental-styles/wiki/Breaking-Changes#0110

  • Fixed bug with the border-bottom for LeftSideNav
  • Fixed a bug with duplicated loading indicator
@UlianaMunich UlianaMunich added this to the Sprint 12 milestone Aug 7, 2020
@UlianaMunich UlianaMunich self-assigned this Aug 7, 2020
@UlianaMunich UlianaMunich added WIP Work in progress and removed WIP Work in progress labels Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant