fix: highlighter error #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobrinyonkov
approved these changes
Jan 6, 2023
kineticjs
force-pushed
the
refactor-highlighter
branch
from
76417e8 to
6816c57
Compare
kineticjs
force-pushed
the
refactor-highlighter
branch
from
6816c57 to
f94bbd8
Compare
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
Findings:
When the DevTools is closed and reopened, the content script containing the highlighter is reloaded
=> the value of _hightlighter global var is overwritten
=> the code in the setDimension function that accesses the _hightlighter by closure cannot find the reference anymore
Solution:
Made the highlighter Singleton and defined _hightlighter as a private field of its single object, to allow referencing it by this._highlighter, rather than closure