Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Animations Settings not Applying Correctly #396

Closed
zhpzhp opened this issue Sep 2, 2024 · 3 comments
Closed

Bug: Animations Settings not Applying Correctly #396

zhpzhp opened this issue Sep 2, 2024 · 3 comments
Assignees
Labels
Bug An error or unexpected behavior. Fixed This issue has been fixed.

Comments

@zhpzhp
Copy link

zhpzhp commented Sep 2, 2024

Game Flavor

Retail

Game Version

11.0.2

Add-On Version

11.0.1

Description

Disable the three options(cast animation, interrupt animation, targeting reticles) in the advanced tab only works until the reload.

Screenshots

1

@StormFX StormFX changed the title Bug: disable cast animation only lasts until reload Bug: Animations Settings not Applying Correctly Sep 2, 2024
@StormFX StormFX added Bug An error or unexpected behavior. In Progress This issue is in progress. labels Sep 2, 2024
@StormFX
Copy link
Member

StormFX commented Sep 2, 2024

I have confirmed this to be a bug. For some reason, the animation events are being registered after the PLAYER_LOGIN event, causing Masque's adjustments to be overridden. The following code should help until I get a release put out. Add this at line 55 of Masque.lua.

-- Events Frame
if WOW_RETAIL then
	local MSQ_EVENTS_FRAME = CreateFrame("Frame")
	MSQ_EVENTS_FRAME:Hide()

	local function OnEvent(...)
		local db = Core.db.profile
		local UpdateEffect = Core.UpdateEffect

		for k, v in pairs(db.Effects) do
			UpdateEffect(k, v)
		end	
	end

	-- Delay the unregistering of events until after `PLAYER_LOGIN`.
	MSQ_EVENTS_FRAME:RegisterEvent("PLAYER_ENTERING_WORLD")
	MSQ_EVENTS_FRAME:SetScript("OnEvent", OnEvent)
end

@zhpzhp
Copy link
Author

zhpzhp commented Sep 2, 2024

Works perfectly! Thank you

@StormFX
Copy link
Member

StormFX commented Sep 2, 2024

You bet. I'll try to get a release sometime this week or next. Busy schedule.

@StormFX StormFX moved this from Todo to In Progress in Client Updates Oct 12, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Client Updates Oct 14, 2024
@StormFX StormFX added Fixed This issue has been fixed. and removed In Progress This issue is in progress. labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error or unexpected behavior. Fixed This issue has been fixed.
Projects
Archived in project
Development

No branches or pull requests

2 participants