Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature refinement module (FRM) points #11

Open
Hussni-V opened this issue Oct 12, 2020 · 1 comment
Open

Feature refinement module (FRM) points #11

Hussni-V opened this issue Oct 12, 2020 · 1 comment

Comments

@Hussni-V
Copy link

According to the paper, the FRM samples five vectors per feature point during feature refinement, However, after a closer look in the code I found out that it is only sampling the center point vector and not the other 4 corners. This setting cannot be changed through the config and is not obvious without looking deep into the code.

I just want to ask why the default setting is as such and not as said in the paper?

@DayBreak-u
Copy link

I see the code with fr:
scalar_t roi_y = bbox_offset[0] * spatial_scale;
scalar_t roi_x = bbox_offset[1] * spatial_scale;

scalar_t px[5] = { roi_x, 0, 0, 0, 0 };
scalar_t py[5] = { roi_y, 0, 0, 0, 0 };

why roi_y is bbox_offset[0] not bbox_offset[1]?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants