Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does snews_pt need so many specific package requirements? #78

Open
sybenzvi opened this issue Jun 2, 2023 · 3 comments
Open

does snews_pt need so many specific package requirements? #78

sybenzvi opened this issue Jun 2, 2023 · 3 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@sybenzvi
Copy link
Contributor

sybenzvi commented Jun 2, 2023

I noticed the current requirements list in snews_pt is pretty specific about all package versions. This seems a bit excessive for most of the requirements, though any dependency on the hop client probably has to be tied to a specific hop minor release. Can we clean this up?

@sybenzvi sybenzvi added the invalid This doesn't seem right label Jun 2, 2023
@joesmolsky
Copy link
Collaborator

joesmolsky commented Jun 2, 2023

Other than hop-client, I don't know if any packages need to be a specific version. I think python needs to be 3.7-3.10 and that is not included in the requirements file. Should it be?

It might be a couple weeks-months before I have time to look into this in detail and test different dependencies. I think @Storreslara or @KaraMelih made the original requirements file and might know more about if specific versions are required for any packages.

@KaraMelih
Copy link
Collaborator

I believe the Python version can be enforced within the setup.py file and not the requirements file.

hop-client and maybe click, setuptools, might require specific versions but the rest should be rather flexible. I agree that one of us should test and relax the requirements

@sybenzvi
Copy link
Contributor Author

sybenzvi commented Jun 2, 2023

OK, I'll come back to this next week and see if we can eliminate the specific versioning for most of the requirements. If it causes problems we'll just roll back the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants