-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate snews-data-formats into snews_pt #123
Open
justinvasel
wants to merge
21
commits into
main
Choose a base branch
from
integrate-snews-data-formats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Big commit alert!
In Python 3.12+ `pkgutil.ImpImporter` is deprecated and removed from `setuptools` starting in v66.1.0.
justinvasel
changed the title
WIP - Integrate snews data formats
Integrate snews-data-formats into snews_pt
Aug 20, 2024
Update run-scenarios to handle snews-data-formats
Default detector name to "Test-Detector" if it is not set by the user.
Integrate snews-data-formats into test-connection functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Requesting testing by other experts to confirm the funcationality still works as expected before merging
Note: This will not be compatible with
snews_cs
untilsnews-data-formats
is integrated into that project as well.This is a major PR which will introduce breaking changes in exchange for a simplified message creation and validation process, and decoupling between
snews_cs
andsnews_pt
.Here is a summary of the changes:
neutrino_time
→neutrino_time_utc
machine_time
→machine_time_utc
sent_time
→sent_time_utc
t_bin_width
→t_bin_width_sec
retract_latest
→retract_latest_n
__init__.py
is moved into__main__.py
datetime.utcnow()
→datetime.now(UTC)
)pyproject.toml
file with pytest configurationrequirements.txt
where necessary (including hop-client -> v.0.10.0)Resolves: #85, #110, #114, #121