Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSpot should not remove Assert.fail() in existing try/catch block #533

Closed
danglotb opened this issue Sep 4, 2018 · 3 comments
Closed

DSpot should not remove Assert.fail() in existing try/catch block #533

danglotb opened this issue Sep 4, 2018 · 3 comments
Assignees
Labels
feature good first issue this issue can be easily handle task available

Comments

@danglotb
Copy link
Member

danglotb commented Sep 4, 2018

Before generating assertions, DSpot removes all the assertions but should not remove Assert.faill() in existing try/catch block.

@danglotb danglotb added feature task available good first issue this issue can be easily handle labels Sep 4, 2018
@danglotb
Copy link
Member Author

danglotb commented Sep 5, 2018

I'm asking myself if DSpot should remove the try/catch block and the Assert.fail() statement because it will regenerate it if the given test still sets the program into an "incorrect" state.

Perhaps, it will allow to derive from a test with try/catch block and Assert.fail() a test that does no set the program into an "incorrect" state.

@monperrus
Copy link
Member

monperrus commented Sep 5, 2018 via email

@danglotb
Copy link
Member Author

danglotb commented Sep 5, 2018

Just before the assert amplification because the input amplification might change the state of the program and the existing assertions can fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue this issue can be easily handle task available
Projects
None yet
Development

No branches or pull requests

2 participants