Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check inputs #605

Closed
Cael35 opened this issue Oct 24, 2018 · 3 comments
Closed

Check inputs #605

Cael35 opened this issue Oct 24, 2018 · 3 comments
Assignees
Labels
feature high priority This issue has the highest priority and should be fixed as soon as possible misuse Problem due to misusage

Comments

@Cael35
Copy link
Member

Cael35 commented Oct 24, 2018

Inputs values are not checked, e.g. a wrong qualified name, and DSpot does not raise the corresponding error

@jesus-gorronogoitia
Copy link
Collaborator

jesus-gorronogoitia commented Oct 24, 2018

Hi @CaelInria Thanks a lot for reporting this issue on behalf myself.
In my experience, a significant number of issues reported by me were caused by a wrong usage of DSpot CLI or by a wrong format or wrong values for some parameters. However, the issues (raised as exceptions) that prevent DSpot to complete the work seemed to be unrelated to the input set, and only after a deep analysis by DSpot developers, it was identified the cause.
Therefore, it would be a great tool usability improvement that:

  • dspot.properties is verified for compliance (well conformance, valid values, etc) before DSpot proceeds with amplification
  • CLI parameters are also verified for compliance, similarly.
    In particular, DSpot can verify the availability of resources declared in the dspot.properties and CLI parameters (e.g. availability of test cases, pathname, etc)

When an issue related to inputs is detected, DSpot can report to the user, stopping the execution.

@jesus-gorronogoitia jesus-gorronogoitia added feature misuse Problem due to misusage labels Oct 24, 2018
@danglotb danglotb added high priority This issue has the highest priority and should be fixed as soon as possible task available labels Oct 24, 2018
@danglotb danglotb self-assigned this Nov 21, 2018
@danglotb
Copy link
Member

Hi, I am working on #659

Do you have any idea on how to check JVM arguments and system properties?

In fact, in DSpot, one can give JVM args (from the properties file) to be specified, for instance, to execute the tests you need specific JVM args.

But, I do not know how to check these arguments (same for system properties).

Thank you.

@jesus-gorronogoitia
Copy link
Collaborator

Hi @danglotb Sorry, I forgot to response to your question. I have no idea about a formal verification. I've been looking for a library on Internet with no success. I think an approach is to proceed internally with the JVM, which will verify passed arguments. Then DSpot can capture and report to the user caller any JVM argument related exception triggered by the JVM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature high priority This issue has the highest priority and should be fixed as soon as possible misuse Problem due to misusage
Projects
None yet
Development

No branches or pull requests

3 participants