Remove not needed casts in generated tests to have more readable tests

[vmassol]

Example of generated test (showing a screenshot that shows in light grey what can be removed)

[vmassol]

BTW a very simple thing to do is to do a static import for import static org.junit.jupiter.api.Assertions.*;. This removes all the Assert. prefixes and make the code more readable too. :)

[vmassol]

Side question: I see this tests calls:

        type.getType().getId();
        type.getDataFormat();
        type.getVersion();

And then does the same assert again. Couldn't dspot decide to not add the second part since calling the getters has no side effects?

[danglotb]

Hi @vmassol

I'll look at the redundant cast.

BTW a very simple thing to do is to do a static import for import static org.junit.jupiter.api.Assertions.*;. This removes all the Assert. prefixes and make the code more readable too. :)

This issue comes from Spoon if I remember. A release is announced on the 11th, February. I'm gonna bump the version used by DSpot.

Couldn't dspot decide to not add the second part since calling the getters has no side effects?

It could. For now, DSpot does not distinguish the "type" of statement between the sequences of assertions. If there is something, (invocation, local variables, etc...) It should generate the second sequence.

Thank you!