-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter news based on campaign or site news #39
Comments
I vote for columns here |
I agree, two columns would be most effective, each one titled "Campaign News" and "Site News" or something like that. I'll work on this next. One question is, would the Site News be blog posts from within WordPress or where would we grab the feed from? |
Yessir -- posts from WP |
Wanted to drop a note on how this is set up, as it's not using the conventional WP Loop: So over in the news template, This gives us a combined collection of the remote & local news. To get them individually, you can separate the two collections like so: $newsFeedService = new NewsFeedService();
$localNews = $newsFeedService->getLocalNewsFeed();
$remoteNews = $newsFeedService->remoteNewsFeedService->getFeed(); The news articles both share a common interface, and you can see in the template how they're used |
Thanks for clarifying this, I was looking at everything and trying to figure out what was going on there. I am a little unfamiliar with doing it this way but it makes sense. And since we're doing this is on home.php this will be the default news layout with two columns. Another question, which column is most important - Site or Campaign? Site news first on the left? would end up on top on mobile. Then campaign on the right, which would end up on the bottom on mobile. |
In previous conversations we had decided that the Site would be the priority content. So basically,
Is exactly on point. |
Allow an easy switch between campaign news and site news. Perhaps put the first 3 site news articles at the top.. Or maybe 2 columns, one for each?
Sites are going to post less frequently than daily campaign posts, so they will get lost FAST.
I'm all for the 2 columns actually
The text was updated successfully, but these errors were encountered: