Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed satellite installer services check test case #8059

Merged

Conversation

devendra104
Copy link
Member

Removed "foreman" from the services list in the test_positive_check_installer_services test case.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #8059 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8059      +/-   ##
==========================================
- Coverage   66.32%   66.27%   -0.06%     
==========================================
  Files          35       35              
  Lines        4149     4175      +26     
==========================================
+ Hits         2752     2767      +15     
- Misses       1397     1408      +11     
Impacted Files Coverage Δ
robottelo/config/base.py 62.64% <0.00%> (-0.24%) ⬇️
robottelo/constants/repos.py 100.00% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074035c...882b2e7. Read the comment docs.

Copy link
Contributor

@mirekdlugosz mirekdlugosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected results in line 1385 still refer foreman-tasks service. Could you remove that reference as well?

LGTM otherwise

@devendra104 devendra104 force-pushed the installer_test_failure_fix branch from daec77d to b79bb61 Compare October 21, 2020 08:46
@devendra104
Copy link
Member Author

Expected results in line 1385 still refer foreman-tasks service. Could you remove that reference as well?

LGTM otherwise

Fixed.

Copy link

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@omkarkhatavkar
Copy link

@devendra104 travis is not happy, can you make it happy?

@devendra104 devendra104 force-pushed the installer_test_failure_fix branch 2 times, most recently from 9fa468a to 98d000c Compare October 22, 2020 16:40
@devendra104 devendra104 force-pushed the installer_test_failure_fix branch from 98d000c to 882b2e7 Compare October 22, 2020 18:00
@omkarkhatavkar omkarkhatavkar merged commit 4ff06d4 into SatelliteQE:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants