[Resolves #494] Add support for s3 in china regions #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngfgrant
reviewed
Apr 15, 2019
ngfgrant
changed the title
ngfgrant
suggested changes
Apr 15, 2019
There was a problem hiding this comment.
Just a small request regarding the list of China regions.
I can't write integration tests as I don't have access to a China region. If you have access to a China region could you edit an integration test to use a China region and run behave integration-tests/ and share the output?
|
tests_results_china_region.txt The tests that are failing are the tests with a specified region (eu-west-X) in the config file. Since China is a different partition a user cannot access China and the rest of AWS at the same time. |
ngfgrant
approved these changes
Apr 16, 2019
ngfgrant
pushed a commit
that referenced
this pull request
May 2, 2019
thawkson
pushed a commit
to thawkson/sceptre
that referenced
this pull request
Feb 6, 2021
Add support for s3 in china region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding support for s3 in china region because the url for the s3 in china is different
PR Checklist
[Resolve #issue-number].make test) are passing.make lint) checks.and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit