Allow BackSolveAdjoint to accept MTKParameters #1131
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -372,11 +372,6 @@ function DiffEqBase._concrete_solve_adjoint( | |||
| saveat = eltype(prob.tspan)[], | |||
| save_idxs = nothing, | |||
| kwargs...) | |||
| if !(sensealg isa GaussAdjoint) && | |||
There was a problem hiding this comment.
If lifting this, then InterpolatingAdjoint and QuadartureAdjoint should also be tested.
There was a problem hiding this comment.
Agreed, that's why I have marked this draft, so I can test, and if necessary add the check back with allowing BacksolveAdjoint through 😅
5 tasks
5 tasks
| @@ -634,9 +634,19 @@ function DiffEqBase._concrete_solve_adjoint( | |||
|
|
|||
| du0 = reshape(du0, size(u0)) | |||
|
|
|||
| dp = p === nothing || p === SciMLBase.NullParameters() ? nothing : | |||
| dp = p === nothing || p === DiffEqBase.NullParameters() ? nothing : | |||
There was a problem hiding this comment.
we can move the refactoring in its own PR. It only happened because the last commit was for getting rid of some conflicts and the merge commit had that diff. Its not in the diff for this PR itself. We need to get some tests for the adjoint paths we expose in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here. Closes #1130