Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of Parsec handle errors and mocked data #8677

Open
mmmarcos opened this issue Oct 8, 2024 · 0 comments
Open

Improve handling of Parsec handle errors and mocked data #8677

mmmarcos opened this issue Oct 8, 2024 · 0 comments
Labels
A-Client Area: Parsec desktop application A-Web Area: Web-related issue I-Javascript Impact: Javascript-related stuff refactor Improve code, don't change behavior

Comments

@mmmarcos
Copy link
Contributor

mmmarcos commented Oct 8, 2024

From @Max-7 #8483 (comment)

I'll have to do a big pass on everything related to how we mock data and how to handle these kind of errors once we got the web bindings.

Related to these kind of code structure found in client that can be problematic in a web-context:

const handle = getParsecHandle();
if (handle !== null && !needsMocks()) {
     // normal case
} else { 
    // error & mock case 
}
@mmmarcos mmmarcos added I-Javascript Impact: Javascript-related stuff A-Client Area: Parsec desktop application A-Web Area: Web-related issue refactor Improve code, don't change behavior labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client Area: Parsec desktop application A-Web Area: Web-related issue I-Javascript Impact: Javascript-related stuff refactor Improve code, don't change behavior
Projects
None yet
Development

No branches or pull requests

1 participant