Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a view that shows the query history #62

Closed
ColinEberhardt opened this issue Sep 14, 2021 · 5 comments
Closed

Add a view that shows the query history #62

ColinEberhardt opened this issue Sep 14, 2021 · 5 comments
Assignees

Comments

@ColinEberhardt
Copy link
Contributor

As suggested in the 2021-09-13 - KDB Project Call - finos/kdb#55

@OiNutter
Copy link
Contributor

How do you feel about using one of these with a list in it?

https://developer.microsoft.com/en-us/fluentui#/controls/web/panel

@ColinEberhardt
Copy link
Contributor Author

That's looks like a neat idea - it's not something you'd want visible all the time.

@OiNutter
Copy link
Contributor

What would the desired interaction be with the entries? I can see a few options:

  1. Click on an entry and it replaces the existing editor contents
  2. Click on an entry and it runs the query without replacing the editor contents
  3. Click on an entry and it runs the query and replaces the editor contents
  4. Click on an entry and it just copies it to the clipboard
  5. An entry has option buttons for copy, replace and run

@OiNutter
Copy link
Contributor

@ColinEberhardt what are your thoughts on this?

@OiNutter OiNutter self-assigned this Oct 19, 2021
@ColinEberhardt
Copy link
Contributor Author

That's a tricky one. My thoughts are ...

  1. Click on an entry and it replaces the existing editor contents - this is a bit 'yuck' and unexpected for the user
  2. Click on an entry and it runs the query without replacing the editor contents - not a bad idea, but how to then edit the query again?
  3. Click on an entry and it runs the query and replaces the editor contents - same issue as (1)
  4. Click on an entry and it just copies it to the clipboard - I kind of like this one, perhaps have a small toast notification that says "copied to clipboard"
  5. An entry has option buttons for copy, replace and run - I like this one too, but could be a little cluttered.

I'm erring towards (4) for the simplicity, it gives the user the option to do whatever they want (and easily too), without having to write too much code :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants