Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book Names and Section Title #17

Open
saengel opened this issue Jun 6, 2024 · 5 comments
Open

Book Names and Section Title #17

saengel opened this issue Jun 6, 2024 · 5 comments

Comments

@saengel
Copy link
Collaborator

saengel commented Jun 6, 2024

Title: Verify language display for book names and section titles.
Test:

  1. Set contentLanguage to translation and open a Hebrew translation text.
  2. Verify that the book name and section title are displayed in English.
  3. Set contentLanguage to source and open an English source text.
  4. Verify that the book name and section title are displayed in Hebrew.
@b-w-cole
Copy link
Collaborator

@saengel , can you tell me (or show me) what contentLanguage is referring to?

@b-w-cole
Copy link
Collaborator

@saengel , can you tell me (or show me) what contentLanguage is referring to?

Nevermind, I got it. Sorry, mixed my terms up!

@b-w-cole
Copy link
Collaborator

Hi @saengel , could you please provide a visual reference for what you are asking for here? I'm not quite seeing the workflow. Thank you in advance!

@saengel
Copy link
Collaborator Author

saengel commented Aug 1, 2024

Hi @b-w-cole - sorry for the delay.

For steps 1 and 2, see the attached screenshot.

Re-reading 3 and 4, it is definitely unclear! My bad for not catching it sooner. I'll need to check with @akiva10b and keep you posted. Maybe start with a different test for now?
Screen Shot 2024-08-01 at 13 29 31

@saengel
Copy link
Collaborator Author

saengel commented Sep 9, 2024

@b-w-cole - here's some clarification for 3 and 4.

In a case where the interface language is set to Hebrew, and we open an English source (i.e. a text that was only ever written in English, and has no Hebrew translation on the site) - we want to make sure that although the text of the content itself is in English, the section names and references appear in Hebrew.

Here's an example of a text that was originally written in English (and we do not have a Hebrew translation on the site): https://www.sefaria.org.il/Gray_Matter_I%2C_Grappling_With_the_Problem_of_Agunot%2C_Coercing_a_Husband_to_Give_a_Get?lang=he

And here's the corresponding explanatory screenshot:

Issue 17 visual

Let me know if you need any further clarification here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants