Error building XPI file

[barancev]

alexei@alexei-xubuntu64:~/se-builder$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working directory clean

alexei@alexei-xubuntu64:~/se-builder$ make xpi
Building latest '/home/alexei/se-builder/build/seleniumbuilder-2.3.2.xpi'...
sed: can't read : No such file or directory
make: *** [xpi] Error 123

[Zarkonnen]

Hm, that was written by @knorrium years ago. Unfortunately I don't speak sed, so I'm less than clear on what's gone wrong. Anyone?

[ghost]

The problem is because @knorrium was probably using Mac (or an old shell on nix) and difference of sed within BSD and GNU. That's why sed -i "" will work for Mac, but for linux sed we should remove "" in the statement.

Code looks not like the best one, should it be bsd/gnu cross compatible?

If you want to run it on modern nix systems:

diff --git a/Makefile b/Makefile
index d489c59..b2f76af 100644
--- a/Makefile
+++ b/Makefile
@@ -18,7 +18,7 @@ help:
 xpi:
        @echo "Building latest '${XPI}'..."
        @mkdir -p ${BUILD}
-       @find . -iname "*.rdf" | xargs grep -l "em:version" | xargs sed -i "" -e 's#<em:version>\([^<][^<]*\)</em:version>#<em:version>${JS_VERSION}</em:version>#'
+       @find . -iname "*.rdf" | xargs grep -l "em:version" | xargs sed -i -e 's#<em:version>\([^<][^<]*\)</em:version>#<em:version>${JS_VERSION}</em:version>#'
        @cd seleniumbuilder; zip -r ../build/${NAME} .
        @echo "File generated at: build/${NAME}" 

Some more issues about this Makefile.

1. why [^<][^<] but not [^<]+ ?
2. why are we trying to match 2.3.3 with \([^<][^<]*\) ? It will never match and will never change the version? Why not just everything between tests?
3. in some cases within Makefile its used find '*.rdf', but somewhere the name of file is hardcoded, that make no sense in fact.

Is it ok if I will refactor the script a bit?

[Zarkonnen]

Please do! A more robust makefile would be extremely useful.