From 64447d4b03f6986337d1ca8d8b6476653570bcc1 Mon Sep 17 00:00:00 2001 From: Puja Jagani Date: Wed, 24 Mar 2021 03:54:12 +0530 Subject: [PATCH] Ensure third party files are available for browser testing (#9323) Co-authored-by: Diego Molina --- java/client/test/org/openqa/selenium/firefox/BUILD.bazel | 4 ++++ .../test/org/openqa/selenium/firefox/FirefoxProfileTest.java | 3 --- java/private/suite.bzl | 1 - 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/java/client/test/org/openqa/selenium/firefox/BUILD.bazel b/java/client/test/org/openqa/selenium/firefox/BUILD.bazel index f9adcd61333b4..81e3f667ddbe8 100644 --- a/java/client/test/org/openqa/selenium/firefox/BUILD.bazel +++ b/java/client/test/org/openqa/selenium/firefox/BUILD.bazel @@ -17,6 +17,10 @@ java_test_suite( tags = [ "requires-network", ], + data = [ + "//third_party/firebug:firebug-1.5.0-fx.xpi", + "//third_party/firebug:mooltipass-1.1.87.xpi", + ], deps = [ "//java/client/src/org/openqa/selenium/firefox", "//java/client/src/org/openqa/selenium/remote", diff --git a/java/client/test/org/openqa/selenium/firefox/FirefoxProfileTest.java b/java/client/test/org/openqa/selenium/firefox/FirefoxProfileTest.java index 28753097c61d4..bdf3957fa2a58 100644 --- a/java/client/test/org/openqa/selenium/firefox/FirefoxProfileTest.java +++ b/java/client/test/org/openqa/selenium/firefox/FirefoxProfileTest.java @@ -161,7 +161,6 @@ public void shouldInstallExtensionFromZip() { } @Test - @Ignore("Need to figure out why files are not showing up") public void shouldInstallWebExtensionFromZip() { profile.addExtension(InProject.locate(MOOLTIPASS_PATH).toFile()); File profileDir = profile.layoutOnDisk(); @@ -170,7 +169,6 @@ public void shouldInstallWebExtensionFromZip() { } @Test - @Ignore("Need to figure out why files are not showing up") public void shouldInstallExtensionFromDirectory() throws IOException { File extension = InProject.locate(FIREBUG_PATH).toFile(); File unzippedExtension = Zip.unzipToTempDir(new FileInputStream(extension), "unzip", "stream"); @@ -181,7 +179,6 @@ public void shouldInstallExtensionFromDirectory() throws IOException { } @Test - @Ignore("Need to figure out why files are not showing up") public void shouldInstallWebExtensionFromDirectory() throws IOException { File extension = InProject.locate(MOOLTIPASS_PATH).toFile(); File unzippedExtension = Zip.unzipToTempDir(new FileInputStream(extension), "unzip", "stream"); diff --git a/java/private/suite.bzl b/java/private/suite.bzl index e57de65612669..68bacbbf9da15 100644 --- a/java/private/suite.bzl +++ b/java/private/suite.bzl @@ -131,7 +131,6 @@ def java_selenium_test_suite( size = None, test_identifiers = ["Test.java"], deps = None, - data = [], jvm_flags = [], tags = [], **kwargs):