From cb98925a1fa149965b3d8a52139ae8034710dcea Mon Sep 17 00:00:00 2001 From: Alex Rodionov Date: Thu, 14 Mar 2024 17:47:14 -0700 Subject: [PATCH] [rb] Enable Edge tests on RBE --- .../selenium/webdriver/spec_support/test_environment.rb | 2 ++ rb/spec/tests.bzl | 8 +++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb index daae1584aaffc..49c29177b0d1b 100644 --- a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb +++ b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb @@ -251,6 +251,8 @@ def chrome_options(args: [], **opts) def edge_options(args: [], **opts) opts[:binary] ||= ENV['EDGE_BINARY'] if ENV.key?('EDGE_BINARY') args << '--headless=chrome' if ENV['HEADLESS'] + args << '--no-sandbox' + args << '--disable-gpu' WebDriver::Options.edge(browser_version: 'stable', args: args, **opts) end diff --git a/rb/spec/tests.bzl b/rb/spec/tests.bzl index f9a1b36bf3b03..809d62c714fd2 100644 --- a/rb/spec/tests.bzl +++ b/rb/spec/tests.bzl @@ -35,14 +35,16 @@ BROWSERS = { "edge": { "data": edge_data, "deps": ["//rb/lib/selenium/webdriver:edge"], - "tags": [ - "skip-remote", # TODO: Add Linux version of Edge to pinned browsers. - ], + "tags": [], "target_compatible_with": [], "env": { "WD_REMOTE_BROWSER": "edge", "WD_SPEC_DRIVER": "edge", } | select({ + "@selenium//common:use_pinned_linux_edge": { + "EDGE_BINARY": "$(location @linux_edge//:opt/microsoft/msedge/microsoft-edge)", + "MSEDGEDRIVER_BINARY": "$(location @linux_edgedriver//:msedgedriver)", + }, "@selenium//common:use_pinned_macos_edge": { "EDGE_BINARY": "$(location @mac_edge//:Edge.app)/Contents/MacOS/Microsoft\\ Edge", "MSEDGEDRIVER_BINARY": "$(location @mac_edgedriver//:msedgedriver)",