Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Selenium.Support.StrongNamed depends on Selenium.WebDeriver instead of strong name signed version #12316

Closed
harunurhan opened this issue Jul 5, 2023 · 3 comments · Fixed by #12861

Comments

@harunurhan
Copy link

What happened?

Selenium.Support.StrongNamed package (available here)depends on Selenium.WebDeriver instead of strong name signed version: Selenium.WebDeriver.StrongNamed.

Also this may cause build issues when a project references both of them, such as warning MSB3243: No way to resolve conflict... since the ``Selenium.WebDerivercomes withSelenium.Support.StrongNamed` and `Selenium.WebDeriver.StrongNamed` might have a name collision.

How can we reproduce the issue?

- Download [selenium-dotnet-strongnamed](https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.8.0/selenium-dotnet-strongnamed-4.8.2.zip)
- Unpack `Selenium.Support.StrongNamed.nupkg`
- Inspect `.nuspec` file
- You will see that the package depends on `Selenium.WebDeriver`, not `Selenium.WebDeriver.StrongNamed`

Relevant log output

N/A

Operating System

Windows

Selenium version

4.8.2

What are the browser(s) and version(s) where you see this issue?

N/A

What are the browser driver(s) and version(s) where you see this issue?

N/A

Are you using Selenium Grid?

No response

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

@harunurhan, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@nvborisenko
Copy link
Member

nvborisenko commented Sep 2, 2023

I think we can ship signed assemblies by default, I don't see reason to build different versions. I mean Selenium.WebDriver package can be signed with strong name.

@nvborisenko nvborisenko added this to the Selenium 5.0 milestone Sep 5, 2023
@nvborisenko nvborisenko removed this from the Selenium 5.0 milestone Oct 3, 2023
Copy link

github-actions bot commented Dec 4, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants