Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[πŸš€ Feature]: Make Selenium Manager classes thin wrappers #13022

Closed
titusfortner opened this issue Oct 22, 2023 · 4 comments
Closed

[πŸš€ Feature]: Make Selenium Manager classes thin wrappers #13022

titusfortner opened this issue Oct 22, 2023 · 4 comments
Assignees
Milestone

Comments

@titusfortner
Copy link
Member

titusfortner commented Oct 22, 2023

Status

Feature and motivation

Make Selenium Manager class only responsible for locating the correct binary, and executing that binary with the provided arguments.

The DriverFinder class parses any options and service class details required and sends them to Selenium Manager.

This allows:

@diemol
Copy link
Member

diemol commented Oct 22, 2023

Do you mean having something like DriverService but for SM?

@titusfortner
Copy link
Member Author

Yes, I guess it's essentially that.

@diemol
Copy link
Member

diemol commented Apr 22, 2024

Implemented in all bindings.

@diemol diemol closed this as completed Apr 22, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants