Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: [rust] Stream Selenium Manager logs to console #13260

Closed
nvborisenko opened this issue Dec 7, 2023 · 9 comments · Fixed by #13414
Closed

[🚀 Feature]: [rust] Stream Selenium Manager logs to console #13260

nvborisenko opened this issue Dec 7, 2023 · 9 comments · Fixed by #13414

Comments

@nvborisenko
Copy link
Member

Feature and motivation

Selenium manager process can be executed with --debug flag, and then process output can be redirected to internal logs. Each time, when the process outputs a message in json format, we can translate it to .net logs.

Usage example

User will be able to see SM output in his log handlers (Console, File).

Copy link

github-actions bot commented Dec 7, 2023

@nvborisenko, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@titusfortner titusfortner added this to the 4.17 milestone Dec 7, 2023
@titusfortner
Copy link
Member

@nvborisenko this is the same as what the other bindings are doing, correct? Thanks.

@nvborisenko
Copy link
Member Author

I guess no. Here I am expecting that each log event, produced by SM, can be routed to the internal logging in binding, real-time.

I also observed that SM doesn't output log messages in real-time..

@titusfortner
Copy link
Member

Yeah, I think we decided that it was more trouble than it was with to try to do it real time.

@titusfortner
Copy link
Member

Should we close this and revisit if we decide to change SM?

@nvborisenko
Copy link
Member Author

Up to you, I just proposed a feature.

@titusfortner
Copy link
Member

Hmm, it's worth being tracked I think. I'm not sure I understood the STDOUT/STDERR differentiation until Simon explained it a few weeks ago. There is probably an improvement here that SM can make.

@titusfortner
Copy link
Member

This would be fixed by #13414

@titusfortner titusfortner changed the title [🚀 Feature]: [dotnet] Stream Selenium Manager logs to internal logging [🚀 Feature]: [rust] Stream Selenium Manager logs to console Jan 17, 2024
@titusfortner titusfortner modified the milestones: 4.17, 4.18 Jan 17, 2024
@diemol diemol modified the milestones: 4.18, 4.19 Feb 16, 2024
@diemol diemol modified the milestones: 4.19, 4.20 Mar 25, 2024
@diemol diemol moved this to In Progress in Selenium Manager Apr 14, 2024
@diemol diemol modified the milestones: 4.20, 4.21 Apr 14, 2024
@diemol diemol removed this from the 4.21 milestone May 10, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
3 participants