Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[πŸ› Bug]: Selenium Should Error if cannot match browserVersion #13418

Closed
titusfortner opened this issue Jan 9, 2024 · 7 comments
Closed

Comments

@titusfortner
Copy link
Member

titusfortner commented Jan 9, 2024

What happened?

Similar to #13352 β€”Β if a user passes in an explicit browserVersion and it cannot be matched for some reason, Selenium should fail instead of using a browser it can find.

How can we reproduce the issue?

selenium-manager", "--browser", "chrome", "--browser-version", "bad", "--language-binding", "ruby", "--output", "mixed", "--debug"]

Relevant log output

DEBUG	chromedriver not found in PATH
DEBUG	chrome detected at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
DEBUG	Running command: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --version
DEBUG	Output: "Google Chrome 120.0.6099.199 "
DEBUG	Detected browser: chrome 120.0.6099.199
DEBUG	Discovered chrome version (120) different to specified browser version (bad)
WARN	There was an error managing chromedriver (chrome bad not available for download (minimum version: 113)); using driver found in the cache
INFO	Driver path: /Users/titusfortner/.cache/selenium/chromedriver/mac-x64/120.0.6099.109/chromedriver
INFO	Browser path: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

Operating System

Mac

Selenium version

sm_mixed_output branch

What are the browser(s) and version(s) where you see this issue?

n/a

What are the browser driver(s) and version(s) where you see this issue?

n/a

Are you using Selenium Grid?

n/a

Copy link

github-actions bot commented Jan 9, 2024

@titusfortner, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented Jan 10, 2024

How would it work in this case when SM is logging errors to stderr and they are not being returned to the main process launched from the bindings? How can we show a good error to the user?

@titusfortner
Copy link
Member Author

titusfortner commented Jan 10, 2024

SM is logging to stderr. If there is an error (status code > 0), the error message is in stdout, and Selenium throws with this info the way it normally does.
This is how SM in the mixed branch works currently
I lied, I was looking at the wrong thing

@diemol
Copy link
Member

diemol commented May 16, 2024

The decision to implement this was made during the Selenium Dev Summit in May 2024.

@Delta456
Copy link
Contributor

I can work on this issue.

@Delta456
Copy link
Contributor

Delta456 commented Oct 8, 2024

Please close this issue as #14511 has been merged.

@github-project-automation github-project-automation bot moved this from High to Done in Selenium Manager Oct 17, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

No branches or pull requests

4 participants