Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Selenium Manager Log Level #13437

Closed
titusfortner opened this issue Jan 14, 2024 · 3 comments
Closed

[🚀 Feature]: Selenium Manager Log Level #13437

titusfortner opened this issue Jan 14, 2024 · 3 comments

Comments

@titusfortner
Copy link
Member

Feature and motivation

If we stream errors from Selenium Manager (#13414), we should be able to set the logging level at whatever Selenium's logging level is set to. So I propose we get rid of --debug and --trace and replace with a generic --log-level that accepts error, warn, info, debug, trace

Usage example

Have this output Debug info:

Logger.getLogger("").setLevel(Level.FINE);
Arrays.stream(logger.getHandlers()).forEach(handler -> {
    handler.setLevel(Level.FINE);
});
new DriverFinder(service, options).getDriverPath();
@bonigarcia
Copy link
Member

I would include --log-level <LEVEL> as proposed, but I would also maintain --debug and --trace, since we already have them. For example, I used these options all the time in development. This way, --log-level debug would be the same as --debug, but both options are possible (and with the second, you write less).

@bonigarcia bonigarcia moved this to In Progress in Selenium Manager Feb 9, 2024
@bonigarcia
Copy link
Member

Closed via #13566.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Selenium Manager Feb 13, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

No branches or pull requests

2 participants