-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🚀 Feature]: Better compatibility with Appium #13949
Comments
@mykola-mokhnach, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
I think so that should suffice. |
I think the issue can be closed as the PR which did the changes suggested here is now merged. |
Thank you @pujagani |
The next monthly release should have the above changes. |
@mykola-mokhnach you can also try out the nightly build https://www.selenium.dev/downloads/#nightly |
This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs. |
Feature and motivation
We would like to improve the compatibility between Appium and Selenium java clients. As the first step it would make sense to avoid using reflection to access various private properties of selenium classes and only rely on public or protected interfaces.
Usage example
Here is the list of changes needed to be done in order to enhance the compatibility:
Increase the scope of private properties of the below classes to 'protected':
RemoteWebDriver -> capabilities
HttpCommandExecutor -> commandCodec
HttpCommandExecutor -> responseCodec
FluentWait -> clock
FluentWait -> timeout
FluentWait -> interval
FluentWait -> sleeper
FluentWait -> ignoredExceptions
FluentWait -> messageSupplier
FluentWait -> input
Make public accessor for the property:
HttpCommandExecutor -> client
DriverService.Builder -> exe
The text was updated successfully, but these errors were encountered: