Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] remove the unused htmlunit-driver from the unit tests #12849

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

joerg1985
Copy link
Member

Description

This change will remove the htmlunit-driver dependency and all references in the unit tests to the htmlunit-driver.
There is functional no change, only testing related changes.

Motivation and Context

The CI is not running any htmlunit-driver tests, it might have done this in the past.
A lot of tests were disabled with NotYetImplemented/Ignore annotations for the htmlunit-driver.

There are a lot of unused dependencies from the htmlunit-driver in the build pipeline.
Even worse, the htmlunit-driver has a dependency back to selenium what should be avoided.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joerg1985 joerg1985 mentioned this pull request Oct 2, 2023
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joerg1985!

@diemol diemol merged commit c64ed7d into SeleniumHQ:trunk Oct 5, 2023
3 checks passed
@rbri
Copy link
Contributor

rbri commented Oct 6, 2023

Thanks @joerg1985,
as discussed last year in Berlin with @diemol it's fine to do that.
A branch of the test suite was used to test the htmlunit-driver in the past, but this branch was not updated since years. And because i have no time to maintain this all i decide some time ago to use a simpler test suite for the htmlunit-driver. And also HtmlUnit itself uses a similar approach to (with a circular dependency between HtmlUnit and the htmlunit-driver :-)). This is also some kind of test so there is no real need to have HtmlUnit in the selenium test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants