-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] handle baseRoute like the hubRoute and the graphqlRoute #13772
Conversation
PR Description updated to latest commit (05cfe37)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
CI Failure Feedback(Checks updated until commit 507ef30)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joerg1985!
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13772 +/- ##
=======================================
Coverage 58.63% 58.63%
=======================================
Files 86 86
Lines 5272 5272
Branches 218 218
=======================================
Hits 3091 3091
Misses 1963 1963
Partials 218 218 ☔ View full report in Codecov by Sentry. |
@joerg1985, as my understanding, this change helps |
@VietND96 no this has been possible before, this PR is only code clean up without a functional change. |
User description
Description
Reworked the
TemplateGridServerCommand.baseRoute
to handle thesubPath
likeTemplateGridServerCommand.hubRoute
andTemplateGridServerCommand.graphqlRoute
are handling it.Motivation and Context
Makes the code better readable and reduces the danger of calling
TemplateGridServerCommand.baseRoute
incorrect.Types of changes
Checklist
Type
enhancement
Description
baseRoute
inTemplateGridServerCommand
to directly return the route for empty prefixes, simplifying route handling.Hub
,Standalone
, andRouterServer
by integratingbaseRoute
directly, removing the need for conditional logic based onsubPath
.baseRoute
usage across different server commands.Changes walkthrough
TemplateGridServerCommand.java
Enhance baseRoute Handling for Empty Prefix
java/src/org/openqa/selenium/grid/TemplateGridServerCommand.java
baseRoute
to handle emptyprefix
by returning the routedirectly.
prefix
is not empty.Hub.java
Simplify Hub Command Route Handling
java/src/org/openqa/selenium/grid/commands/Hub.java
appendRoute
by integratingbaseRoute
directly withsubPath
and
routerWithSpecChecks
.baseRoute
addition based onsubPath
emptiness.Standalone.java
Streamline Standalone Command Route Configuration
java/src/org/openqa/selenium/grid/commands/Standalone.java
baseRoute
directly intoappendRoute
for cleaner handling.baseRoute
based onsubPath
.RouterServer.java
Refactor RouterServer Route Setup
java/src/org/openqa/selenium/grid/router/httpd/RouterServer.java
baseRoute
inappendRoute
for a more straightforward approach.baseRoute
based onsubPath
presence.