-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Run remote tests on RBE #13906
[rb] Run remote tests on RBE #13906
Conversation
CI Failure Feedback(Checks updated until commit 4935792)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
7cdb8b2
to
4935792
Compare
CI Failure Feedback 🧐(Checks updated until commit 700ee6d)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
5244527
to
abe368d
Compare
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Theoretically should we run all the RBE skipped tests on GitHub ubuntu?
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Changes walkthrough 📝
driver_spec.rb
Exclude remote drivers from concurrent start test
rb/spec/integration/selenium/webdriver/driver_spec.rb
profile_spec.rb
Exclude remote drivers from profile reuse test
rb/spec/integration/selenium/webdriver/firefox/profile_spec.rb
.skipped-tests
Update skipped tests list for remote and BiDi
.skipped-tests
spec_helper.rb
Add RBE environment condition
rb/spec/integration/selenium/webdriver/spec_helper.rb
test_environment.rb
Enhance test environment for RBE and driver configurations
rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
tests.bzl
Update test configurations for remote execution
rb/spec/tests.bzl
ci-ruby.yml
Update CI workflow for Ruby tests
.github/workflows/ci-ruby.yml