-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] use common annotations in BiDi tests #14702
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Here are some number for this PR, from my local trunk: Elapsed time: 2211.549s, Critical Path: 411.28s |
CI Failure Feedback 🧐
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you so much @joerg1985!
User description
Motivation and Context
This PR will use the common annotations in the BiDi tests to ensure the driver is restarted.
Additionally the provided NettyAppServer is used and not started before each test.
On my local system it takes ~500ms to start the NettyAppServer, this is how i stumbled into this.
I will improve the startup of the NettyAppServer as soon as this is merged.
@pujagani could you hava a look at this?
Types of changes
Checklist
PR Type
enhancement, tests
Description
@BeforeEach
and@AfterEach
annotations, replacing them with@NeedsFreshDriver
to ensure a fresh driver for each test.server
withappServer
in test classes to standardize server usage.@BeforeAll
and@AfterAll
annotations inRemoteWebDriverBiDiTest
for server lifecycle management.Changes walkthrough 📝
16 files
BiDiTest.java
Refactor BiDiTest to use common annotations and appServer
java/test/org/openqa/selenium/bidi/BiDiTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.server
withappServer
.BrowserCommandsTest.java
Refactor BrowserCommandsTest to use common annotations
java/test/org/openqa/selenium/bidi/browser/BrowserCommandsTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.BrowsingContextInspectorTest.java
Refactor BrowsingContextInspectorTest to use common annotations
java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.BrowsingContextTest.java
Refactor BrowsingContextTest to use common annotations and appServer
java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.server
withappServer
.LocateNodesTest.java
Refactor LocateNodesTest to use common annotations
java/test/org/openqa/selenium/bidi/browsingcontext/LocateNodesTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.ReleaseCommandTest.java
Refactor ReleaseCommandTest to use common annotations and appServer
java/test/org/openqa/selenium/bidi/input/ReleaseCommandTest.java
@BeforeEach
annotation.@NeedsFreshDriver
annotation to test methods.server
withappServer
.SetFilesCommandTest.java
Refactor SetFilesCommandTest to use common annotations
java/test/org/openqa/selenium/bidi/input/SetFilesCommandTest.java
@BeforeEach
annotation.@NeedsFreshDriver
annotation to test methods.LogInspectorTest.java
Refactor LogInspectorTest to use common annotations and appServer
java/test/org/openqa/selenium/bidi/log/LogInspectorTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.server
withappServer
.AddInterceptParametersTest.java
Refactor AddInterceptParametersTest to use common annotations
java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.NetworkCommandsTest.java
Refactor NetworkCommandsTest to use common annotations and appServer
java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.server
withappServer
.NetworkEventsTest.java
Refactor NetworkEventsTest to use common annotations and appServer
java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.server
withappServer
.CallFunctionParameterTest.java
Refactor CallFunctionParameterTest to use common annotations
java/test/org/openqa/selenium/bidi/script/CallFunctionParameterTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.EvaluateParametersTest.java
Refactor EvaluateParametersTest to use common annotations
java/test/org/openqa/selenium/bidi/script/EvaluateParametersTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.ScriptCommandsTest.java
Refactor ScriptCommandsTest to use common annotations and appServer
java/test/org/openqa/selenium/bidi/script/ScriptCommandsTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.server
withappServer
.ScriptEventsTest.java
Refactor ScriptEventsTest to use common annotations and appServer
java/test/org/openqa/selenium/bidi/script/ScriptEventsTest.java
@BeforeEach
and@AfterEach
annotations.@NeedsFreshDriver
annotation to test methods.server
withappServer
.RemoteWebDriverBiDiTest.java
Refactor RemoteWebDriverBiDiTest for server lifecycle management
java/test/org/openqa/selenium/grid/router/RemoteWebDriverBiDiTest.java
@BeforeAll
and@AfterAll
annotations for server setup andteardown.
@BeforeEach
annotation for server setup.