-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Add nullability annotations to Proxy
#14861
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Thx Michael! |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add nullability annotations to
Proxy
. Dictionary lookups are significantly improved, with double- or triple-lookups turning into a single one.Motivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
enhancement
Description
Proxy
class to improve code safety and clarity.TryGetValue
method calls.Changes walkthrough 📝
Proxy.cs
Add nullability annotations and optimize dictionary lookups
dotnet/src/webdriver/Proxy.cs
Proxy
class.TryGetValue
.